Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to see if PHP > 5.6 and always_populate_raw_post_data = -1 #1062

Merged
merged 2 commits into from
Mar 20, 2015
Merged

Add check to see if PHP > 5.6 and always_populate_raw_post_data = -1 #1062

merged 2 commits into from
Mar 20, 2015

Conversation

RMcLeod79
Copy link

Fix for issue #1057

$HTTP_RAW_POST_DATA has been deprecated in PHP 5.6 the ini setting is commented out by default however this causes PHP to throw an E_DEPRECATED notice whenever it receives post data that isn't application/x-www-form-urlencoded (e.g. application\json).

This is causing the database check to fail during Web Setup as Angular JS posts application\json by default. This fix checks the users PHP version and the value of always_populate_raw_post_data and warns if they are using PHP >= 5.6.0 and always_populate_raw_post_data isn't explicitly set to -1

@anupdugar
Copy link
Contributor

@RMcLeod79 Thank you for your contribution! We will review the changes and process it internally through ticket MAGETWO-33491.

@sshrewz
Copy link

sshrewz commented Mar 9, 2015

We are currently processing this pull request and this should be available by end of this week. Thank you for your contribution!

vrann added a commit that referenced this pull request Mar 20, 2015
Add check to see if PHP > 5.6 and always_populate_raw_post_data = -1
@vrann vrann merged commit b6927e0 into magento:develop Mar 20, 2015
@RMcLeod79 RMcLeod79 deleted the Issue-1057 branch March 23, 2015 09:16
@pronto2000
Copy link

Any news about this issue? I mean I installed latest version from Git and database connection test ajax request returns following:

<br /> <b>Deprecated</b>: Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead. in <b>Unknown</b> on line <b>0</b><br /> <br /> <b>Warning</b>: Cannot modify header information - headers already sent in <b>Unknown</b> on line <b>0</b><br /> {success: true}

@ghost
Copy link

ghost commented Aug 18, 2015

@pronto2000
Copy link

I think this option will be removed from upcoming PHP 7?

@ghost
Copy link

ghost commented Aug 18, 2015

Correct but I expect Magento will continue to support PHP 5.6 and until PHP 7 is released, it's not mentioned in the install guide at all.

magento-team pushed a commit that referenced this pull request Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants