Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for select and multiselect to ignore corrupted attributes #1087

Merged
merged 1 commit into from
May 22, 2015

Conversation

dimajanzen
Copy link
Contributor

No description provided.

@kokoc
Copy link
Member

kokoc commented Mar 17, 2015

@dimajanzen Thank you for contribution.

Could you please explain what does "corrupted attribute" mean?

@dimajanzen
Copy link
Contributor Author

@kokoc of course.

There are a lot of magento extension that creates attributes through install scripts where the source_model is accidentally set. That cause an validation issue during magento import, because the validation checks only the attributeType and that is set to select.

sample attribute:
"attribute_id": "980",
"entity_type_id": "10",
"attribute_code": "google_category",
"attribute_model": null,
"backend_model": "",
"backend_type": "varchar",
"backend_table": null,
"frontend_model": null,
"frontend_input": "text",
"frontend_label": "Google Category",
"frontend_class": null,
"source_model": "eav/entity_attribute_source_table",

@kokoc
Copy link
Member

kokoc commented Mar 23, 2015

CR: passed
Builds: green
Internal reference: MAGETWO-35406

@vpelipenko vpelipenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 21, 2015
@vpelipenko vpelipenko added Progress: accept in progress and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels May 14, 2015
magento-team pushed a commit that referenced this pull request May 22, 2015
MAGETWO-35406 [GITHUB] check for select and multiselect to ignore corrupted attributes #1087
@magento-team magento-team merged commit 5e64d08 into magento:develop May 22, 2015
@kokoc
Copy link
Member

kokoc commented May 27, 2015

@dimajanzen Your pull request is merged in in 0.74.0-beta10. Thank you very much for your contribution and continued support to Magento 2!

magento-team pushed a commit that referenced this pull request May 11, 2017
[Falcons]: Delivery of Bugfixes for Deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants