Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed occurances of implode with wrong argument order #1126

Merged
merged 1 commit into from
Mar 27, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Fedex/Setup/InstallData.php
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function install(ModuleDataSetupInterface $setup, ModuleContextInterface
$mapNew[] = $shippingMethod;
}
}
$mapNew = implode($mapNew, ',');
$mapNew = implode(',', $mapNew);
} else {
continue;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<?php foreach ($_specificInfo as $_label => $_value):?>
<tr>
<th><?php echo $block->escapeHtml($_label)?>:</th>
<td><?php echo nl2br(implode($block->getValueAsArray($_value, true), "\n"))?></td>
<td><?php echo nl2br(implode("\n", $block->getValueAsArray($_value, true)))?></td>
</tr>
<?php endforeach; ?>
</table>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

<?php if ($_specificInfo = $block->getSpecificInformation()):?>
<?php foreach ($_specificInfo as $_label => $_value):?>
<?php echo $_label ?>: <?php echo implode($block->getValueAsArray($_value), ' ')?>{{pdf_row_separator}}
<?php echo $_label ?>: <?php echo implode(' ', $block->getValueAsArray($_value))?>{{pdf_row_separator}}
<?php endforeach; ?>
<?php endif;?>

<?php echo implode($block->getChildPdfAsArray(), '{{pdf_row_separator}}') ?>
<?php echo implode('{{pdf_row_separator}}', $block->getChildPdfAsArray()) ?>
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<?php foreach ($_specificInfo as $_label => $_value):?>
<tr>
<th scope="row"><?php echo $block->escapeHtml($_label)?></th>
<td><?php echo nl2br(implode($block->getValueAsArray($_value, true), "\n"))?></td>
<td><?php echo nl2br(implode("\n", $block->getValueAsArray($_value, true)))?></td>
</tr>
<?php endforeach; ?>
</table>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ protected function _actionsToHtml(array $actions = [])
$attributesObject->setData($action['@']);
$html[] = '<a ' . $attributesObject->serialize() . '>' . $action['#'] . '</a>';
}
return implode($html, '');
return implode('', $html);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ protected function _applyRulesFilter()
}

if (!empty($rulesFilterSqlParts)) {
$this->getSelect()->where(implode($rulesFilterSqlParts, ' OR '));
$this->getSelect()->where(implode(' OR ', $rulesFilterSqlParts));
}
return $this;
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Tax/Setup/InstallData.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function install(ModuleDataSetupInterface $setup, ModuleContextInterface
'visible_in_advanced_search' => true,
'used_in_product_listing' => true,
'unique' => false,
'apply_to' => implode($taxSetup->getTaxableItems(), ',')
'apply_to' => implode(',', $taxSetup->getTaxableItems())
]
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function processAssert(CatalogProductIndex $productGrid, ConfigurableProd
}
}

\PHPUnit_Framework_Assert::assertEmpty($errors, implode($errors, ' '));
\PHPUnit_Framework_Assert::assertEmpty($errors, implode(' ', $errors));
}

/**
Expand Down