Classmap needs to be prepended to autoloader stack to have any effect #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix have been added into the internal repository. Code changes will be available after one of the next code publications to the GitHub from the internal repository. Thank you. |
magento-team
added a commit
that referenced
this pull request
Apr 7, 2013
* Product creating & editing:
* Added ability to control base text styling without WYSIWYG when editing description fields
* Added validation for price and quantity fields
* Removed category suggest limit
* Product template management:
* Automatically update Product Template when modifying structure in Create Product flow
* Improvements to change attribute set functionality
* Refactored JavaScript to use JQuery library:
* Refactored the following pages: catalog tags, one page checkout, multishipping checkout, gift options, gift messages (across the board)
* Converted jQuery popupwindow.js plugin to a jQuery widget
* Replaced Prototype code for Switch/Maestro and Solo credit card with jQuery widget
* Replaced Prototype Validation with jQuery validation plugin
* Converted credit card payment tool tip to jQuery in all themes
* Removed legacy JS files from all themes
* Various improvements in look & feel of backend UI:
* Styling of components: catalog, sales, customers, reports, CMS, newsletter
* Generic styling: grids, popup windows
* Changes to support IE browser
* Enhancements in "suggest" JavaScript widget:
* Ability to delete selected item using keyboard
* Ability to display all available search items, if "recent items" is empty
* Fixes of behavior of currently selected elements and "spinner"
* Display "No Records" message in suggest widget if all items already selected
* Fixed suggest widget to no longer show deleted items
* Improved `Magento_Test_Helper_ObjectManager` in unit tests to discover types of constructor arguments
* Removed workaround of unsetting objects referenced in `tearDown()` of integration tests
* Updated Menu and Navigation layout, including redesigned backend menu item System -> My Account
* Made store address format consistent with format of shipping origin address
* Added ability to navigate directly to a section in backend system configuration, with corresponding accordion expanded
* Removed some of unnecessary coupling between several modules
* General improvements to unit and integration test code coverage, as well as compliance with coding standards
* Application framework:
* Implemented ability to compress/decompress data in a cache backend
* Verified ability to disable in configuration triggering of system upgrade
* Abolished code pools and the mechanism of overriding files using include\_path (without alternative)
* Implemented segmentation of cache by types -- ability to assign separate cache configuration per type. Reviewed and verified possibility to isolate configuration cache segment
* Segregated application configuration into several layers. Primary configuration is used by the object manager and loaded before application is initialized
* Instead of `Zend\Di`, implemented `Magento\ObjectManager` library that has less features and suits Magento application needs better in terms of performance
* Introduced "context" object as dependencies for super-classes (`Mage_Core_Model_Abstract`, `Mage_Core_Block_Abstract`, etc) to reduce complexity of their constructors' API
* Implemented tools for pre-populating all auto-generated proxy and factory classes, used by dependency injection framework
* Replaced "developer" mode with general "mode", that has 3 states: developer, default, production
* In "production" mode, the application will not invoke fallback for static view files (images, CSS-files, JavaScript). Instead, it will assume that they are already placed in a fully qualified location. Added tools for populating static view files from `app` directory into `pub/static`
* Introduced support for Twig templating
* template rendering, including phtml, was abstracted into a 'Template Engine' to make support for other template engines easier
* included Magento-specific Twig functions and filters
* phtml templates can now only access public methods of the corresponding Block class
* ability to define dependencies on data provided by a service that is then made available to the templates -- eliminates some of the code in Blocks
* Introduced support for webhooks and callbacks: outbound HTTP requests for notifications and real-time integrations
* Added ability to define options for System Configuration select fields in XML: static options are defined inline, dynamic options can reuse data provided by a service
* Moved product business logic found in blocks into `Mage_Catalog_Service_Product` to consolidate logic into a single structure that both controllers and web services can invoke
* Converted product view page to demonstrate use of Twig templates and services
* Updated shipping carrier `collectRates` logic to support remote callbacks and converted the FedEx shipping carrier to comply with the same interface
* Added webhook support for the following topics: `customer/created`, `customer/updated`, `customer/deleted`, and `order/created`
* Visual design editor:
* Ability to view all CSS-files of a theme
* Ported numerous features of visual design editor from Magento Go 1.x to Magento Core 2.x: style editing, managing catalog images
* Various improvements in UI
* Improved image sizing functionality
* Improved test coverage
* Ability to launch physical themes, including workflow preview mode and workflow design mode
* Ability to duplicate existing themes for customization
* GitHub requests
* [#162](#162) -- classmap needs to be prepended to autoloader stack to have any effect
* [#179](#179) -- fix that makes `Mage_Install` compatible with the new version of SimpleXml
* [#180](#180) -- fixed `getBaseUrl()` when type was injected via setter
* [#203](#203) -- fixed problem with login in to backend area on php 5.4
* [#216](#216) -- explicit nullification of `$_store` in `Mage_Core_Model_Sore_Storage_Db->_initStores()`
* [#220](#220) -- make topmenu HTML editable by an event
* [#221](#221) -- changed minimum required PHP version from PHP 5.2.3 to 5.3.3
* Bug fixes:
* Restored missing Paypal configuration options
* Fixed numerous display issues on the following pages: admin login, product management, category management, CMS poll, VDE, tax, shipping
* Fixed XSS vulnerability related to customer data & bundle options
* Fixed "Preview Theme" functionality
* Fixed JS File upload problem with Internet Explorer
* Replaced `truncateOptions` function in `varien/js.js` with inline widget
* Fixed broken XPaths in `SystemConfiguration.yml`
* Fixed jQuery metadata plugin's data attribute scanning for validation
* Synchronized default value of `quantity_and_stock_status` with Stock Availability control
* Fixed display of G.T. Purchased column in Order grid when order in non-default currency
* Fixed Foreign Key support for MS SQL
* Fixed "Create Customer" functionality on New Order screen
* Restored State/Province field to Review Order page
* Fixed Add New Tax Rate functionality
* Fixed problem with displaying New Shopping Cart Price Rule tab
* Fixed problem of configurable product options getting lost when adding product to wishlist
* Fixed UPS Shipping label printing
* Fixed performance issue with Catalog Management
* Fixed input file type validation when importing customers
* Fixed custom product placeholder image display
* Added missing files referenced by `quick\_style.css`
* Fixed validation error messaging and message placement
* Fixed access problem to SOAP/XML User and Roles pages
* Fixed access problem created when editing your own permissions
* Several fixes for problems with cleaning cache in tag scope
* Fixed invalid link problem in Gift Card email
* Fixed problem with deleting selected product category after changing attribute set
* Fixed theme management for Windows by adopting `Magento_Filesystem` abstraction to access directories
* Fixed cart rendering in case of empty cart
* Remove duplicate "Link to Store Front" link from admin, made obsolete by "Customer View" link
* Removed "Flat Rate" from pre-installed shipping methods
magento-engcom-team
added a commit
that referenced
this pull request
Oct 10, 2018
…ubscription #162 - Merge Pull Request magento/graphql-ce#162 from comwrap/graphql-ce:55-56-account-mutations - Merged commits: 1. 09dc09c 2. ef7f579 3. 8963811 4. d0dd90f 5. b691d84 6. d759867 7. a1dd683 8. cc8d328 9. 9200a16 10. 2057ddf 11. 20e3393 12. 661988b 13. 706af91 14. a1c4d33 15. 0cb378b 16. 6e6b5c3 17. 6f73325 18. 7ca6097
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 10, 2018
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 2, 2023
LYNX-258 & LYNX-259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file var/classmap.ser exists an additional autoloader will be registrered that loads class according to a classmap instead of the include path, (which btw is an awesome improvement!)
Problem is, that the new autoloader will be appended to the autoloader stack resulting in all files being autoloaded be the includepath autoloader first (which will find all files and will never process to the classmap autoloader).
The function spl_autoload_register has a third parameter that allows to prepend the new autoloader instead of appending it.
Another solution would be to move the complete classmap autoloader a couple of lines up in bootstrap.php before the regular autoloader.