11615: Fix UrlRewriteGenerator for anchor categories

[obuchowski]

A commit itself is pretty straightforward. Need to pass storeId param to category repository so resulted category has a correct url path.

Description (*)

For not default stores adding a category for a product may result in wrong url rewrite for a product in category's anchor parent .

Fixed Issues (if relevant)

1. #11615

Manual testing scenarios (*)

1. Enable this
   
2. Change url key of some anchor category in a specific (NOT DEFAULT) store
   
3. add a product to a child category from a product form
   
   Note that there is a correct result if a product is added from a category form.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @obuchowski. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[hostep]

Let's also link to the corresponding PR for 2.2-develop: #14344

[obuchowski]

Thank you @hostep
Sorry, I found a related issue and existing pull request right before I finished a creation of this one.
Anyway, I find it ridiculous that this issue is living for 15 months and a solution was provided almost a year ago.
The business logic as well as fix itself are very clear.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-4076 has been created to process this Pull Request

[magento-engcom-team]

@obuchowski thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[obuchowski]

@VladimirZaets thank you guys. Pull requests accepting process has significantly accelerated compared with previous years. Great work.

[VasylShvorak]

✔️ QA passed

[sidolov]

Hi @obuchowski , we found huge performance degradation on the scenario:: Get category via API with provided changes, can you take a look?
Thank you!

[hostep]

@sidolov: how can this change have influence on getting category data? Are url rewrites being generated while just getting category data? That wouldn't make any sense?

[VladimirZaets]

@obuchowski, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

[m2-assistant]

Hi @obuchowski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[hostep]

Closing this is ridiculous, I'm reopening.

[m2-assistant]

Hi @obuchowski. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sivaschenko]

@obuchowski please sign the Adobe CLA so that we can further process this PR

[ihor-sviziev]

Hi @obuchowski,
Will you be able to sign Adobe CLA?

[lenaorobei]

@obuchowski unfortunately, we will not be able to process this PR without signed CLA.

[lenaorobei]

I run performance tests on this branch, everything is ✅
The only thing is missing - CLA.

[hostep]

@lenaorobei: so why has this ticket taken sooo long to get processed, first Magento staff is complaining that it causes performance issues and refuses to merge it, and now all of the sudden there's no problem anymore?
The CLA was already signed before, it's just the new CLA which was introduced some months ago which isn't signed yet.

If that's the only thing blocking this PR from merging, I'll create a new one in a couple of days.

[lenaorobei]

@hostep it's not an excuse, but the reason is a huge amount of open PRs. CLA is the only thing. Sorry about that and I hope for your understanding.

[hostep]

Added a new PR: #26784

Unless @obuchowski starts responding again, we can probably close this one?

[ihor-sviziev]

Hi @obuchowski,
I’m closing this PR due to inactivity and now we have another PR #26784 that doing the same without this issue.
In case if you would like to sign CLA and finish this PR - just reopen this PR and write the comment.
Thank you for contribution!

[m2-assistant]

Hi @obuchowski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.