Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Rich Snippet Code #233

Closed
wants to merge 3 commits into from
Closed

Google Rich Snippet Code #233

wants to merge 3 commits into from

Conversation

hectorj
Copy link

@hectorj hectorj commented Feb 19, 2013

Added some simple Rich Snippets in product view http://www.schema.org/Product
(many more can be added)

@akira28
Copy link

akira28 commented Feb 25, 2013

Nice! I think it would be cool to also add those from http://schema.org/AggregateOffer

@hectorj
Copy link
Author

hectorj commented Feb 25, 2013

As far as I know a basic Magento doesn't have aggregated offers, only offers ( http://schema.org/Offer )
I started adding Offer snippet, but I only added price property at this time.
Don't hesitate to contribute, it doesn't require high development skills, just reading and applying documentations here : http://support.google.com/webmasters/bin/answer.py?hl=en&answer=99170 , http://schema.org/docs/documents.html (that is the only thing I did, I had no experience with rich snippets before)
And you can test the result with that tool : http://www.google.com/webmasters/tools/richsnippets (I forgot to do that, I'll do it soon and correct my code if necessary)

@Kristenhanna
Copy link

Good one. I also integrated rich snippet in my magento store using magento google rich snippets extension and it was really good and all my products are showing visible on google search results. This is one of the good feature I guess. And also customers will also be able to find easier to choose the best product from the rating and review displayed in the search results.

@amenk
Copy link
Contributor

amenk commented Jul 4, 2013

Totally +1 ... rich snippets are very hard to add via an extension as they require lots of template changes. So this is something which would be great in the default templates.

@powerprolive
Copy link

Good stuff. Thanks for posting.
Using Magento 1.7.0.2. Have updated three files as indicated. A few variations for placement of code were needed. Not sure if original notes were from 1.7.0.2.

Have an error:
Error: Incomplete microdata with schema.org.
It's the Price snippet that throws the error. Looking into it in the next opportunity to review.

Resolved error.
File: price.phtml
itemprop="price" needs to show prior to price shown. Updated on Line 200:

@verklov
Copy link
Contributor

verklov commented Nov 7, 2013

Hello hectorj,
Sorry for the delay with the response.
Thank you for your contribution! We will consider including this in a future release.

magento-team added a commit that referenced this pull request Nov 22, 2013
* Moved general action-related functionality to \Magento\App\Action\Action in the library. Removed Magento\Core\Controller\Varien\Action and related logic from the Magento_Core module
* Moved view-related methods from action interface to \Magento\App\ViewInterface with corresponding implementation
* Moved redirect creation logic from the action interface to \Magento\App\Response\RedirectInterface
* Moved Magento\Core common blocks to the library
* Added reading of etc/integration/config.xml and etc/integration/api.xml files for API Integrations
* Various improvements:
  * Email-related logic from the Core and Adminhtml modules consolidated in the new Email module
* GitHub requests:
  * [#238](#238) -- Improve escaping HTML entities in URL
  * [#199](#199) -- Replaced function calls to array_push with adding the elements directly
  * [#182](#182) -- By default use collection _idFieldName for toOption* methods.
  * [#233](#233) -- Google Rich Snippet Code
  * [#339](#339) -- Correcting 'cahce' typo in documentation.
  * [#232](#232) -- Update app/code/core/Mage/Checkout/controllers/CartController.php (fix issue #27632)
* Fixed bugs:
  * Fixed JavaScript error when printing orders from the frontend
  * Fixed Captcha problems on various forms when Captcha is enabled on the frontend
  * Fixed "Page not found" on category page if setting "Add Store Code to Urls" to "Yes" in the backend config
  * Fixed Fatal error when creating shipping label for returns
@verklov
Copy link
Contributor

verklov commented Nov 25, 2013

Hello hectorj,
We have processed your pull request. The code should be available in version dev53 release last Friday.

Thank you for your contribution!

@navarr
Copy link
Member

navarr commented Feb 27, 2015

+1 Awesome contribution.

magento-team pushed a commit that referenced this pull request Apr 20, 2015
[Firedrakes] Concurrent Order Management
magento-team pushed a commit that referenced this pull request Dec 9, 2015
[MPI] Sprint 73 Functional tests and Bugfix
mmansoor-magento pushed a commit that referenced this pull request Aug 11, 2016
Fixed issue:
 - MAGETWO-55970 [FT] Constraint AssertProductQtyInMiniShoppingCart is absent

Functional tests:
 - MTA-3383 Catalog Widget: Extend existing functional automated tests. Cache
 - MTA-3242 Reports: Extend existing functional automated tests
 - MTA-3241 Catalog Widget: Extend existing functional automated tests
 - MTA-3237 Downloadable: Extend existing functional automated tests
 - MTA-3483 Create pull request and deliver extended functional tests to mainline
 - MTA-3437 \Magento\Config\Test\Handler\ConfigData\Curl handler doesn't allow to save values for different website scopes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants