-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update laminas-crypt to PHP8 compatible version #32200
Update laminas-crypt to PHP8 compatible version #32200
Conversation
Hi @hws47a. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
df84478
to
4f8d9c2
Compare
@magento run all tests |
@magento run Static Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix failing static tests?
Hi @ihor-sviziev, They are failing in B2B and EE. And they are fixed in the related PR (see description) |
@magento run Functional Tests B2B, Static Tests |
@sidolov @sivaschenko could you help to link the related PR correctly? it's not getting detected now, as result tests are failing |
@ihor-sviziev thanks, updated. @hws47a the format of related PR link should be precise as it is parsed from the description for the tests: https://devdocs.magento.com/contributor-guide/pull-request-tests.html#related-pull-requests |
@magento run all tests |
@magento run Functional Tests EE |
Hi @hws47a, thank you for your contribution! |
Description (*)
Update laminas-crypt to ^3.4.0 for PHP8 compatibility
Fixed Issues (if relevant)
Related pull requests
https://github.com/magento/partners-magento2ee/pull/499
Contribution checklist (*)