Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update laminas feed to be PHP8 compatible #32473

Merged

Conversation

hws47a
Copy link
Contributor

@hws47a hws47a commented Mar 13, 2021

Description (*)

Set laminas feed version as ^2.13.0 to be PHP8 compatible

It turned out that it's already updated in composer.lock to 2.13.1 as it was allowed by ^2.9.0.
So no packages are actually updated. Probably no testing needed.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/527

Fixed Issues (if relevant)

  1. Fixes Update laminas/laminas-feed dependency version to "^2.13.0" #31340

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 13, 2021

Hi @hws47a. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me php8-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@hws47a
Copy link
Contributor Author

hws47a commented Mar 14, 2021

@magento run all tests

@hws47a hws47a changed the title #31340 Update laminas feed in composer.json Update laminas feed to be PHP8 compatible Mar 14, 2021
@hws47a
Copy link
Contributor Author

hws47a commented Mar 14, 2021

@magento run Unit Tests

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes from this PR.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 15, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Unit Tests

@magento-cicd2 magento-cicd2 merged commit 4857df9 into magento:php8-develop Mar 15, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 15, 2021

Hi @hws47a, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Monsoon partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Project: PHP8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants