-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify setup wizard 2 #32513
Simplify setup wizard 2 #32513
Conversation
Hi @hws47a. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
@magento run Functional Tests CE |
1 similar comment
@magento run Functional Tests CE |
@ihor-sviziev, previous was simplifying controllers and removing angular. This one is removing "lazy controller" and unnecessary dependencies |
1a13b7d
to
b026746
Compare
@magento run all tests |
@ihor-sviziev it actually replaces #32449 |
@magento run Functional Tests CE |
1 similar comment
@magento run Functional Tests CE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests looks not related to changes from this PR.
Hi @hws47a, thank you for your contribution! |
"laminas/laminas-http": "^2.6.0", | ||
"laminas/laminas-i18n": "^2.7.3", | ||
"laminas/laminas-json": "^3.2.0", | ||
"laminas/laminas-log": "^2.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was laminas/laminas-log
removed?
Description (*)
Simplify setup wizard code:
Note:
Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/528
Fixed Issues (if relevant)
Manual testing scenarios (*)
Check that
/setup/
still worksContribution checklist (*)