Replacing simple preg calls with less expensive alternates

[parhamr]

Changes

• Replaces simple preg_match calls with equivalent substr, strpos, and/or strlen checks
• Replaces simple preg_split calls with equivalent explode operations

Testing

• Code review, please
• No functional changes

[verklov]

Hello parhamr,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

[orlangur]

preg_split -> explode change seems to be reasonable, but combinations of substr/strpos/strlen mess up the code.

Did you measure the gain within real application? Referring to this comment: any code change without evidence of performance improvement is premature optimization.

[parhamr]

I’m not sure what you mean by mess up the code; those function names describe exactly their intent and purpose.

No, I did not measure any changes. This is a matter of PHP best practices and code style and it’s up to your organization to determine what standards and quality are acceptable for your core product.

[IvanChepurnyi]

@orlangur Please check official PHP documentation about preg_match. There is a good note from PHP core team:

Tip
Do not use preg_match() if you only want to check if one string is contained in another string. Use strpos() or strstr() instead as they will be faster.

[verklov]

parhamr,
Our team has processed your pull request. The code is available in the version dev56 recently released.

Thank you for your contribution! Looking forward for your new contributions.