Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit 3.8 Compatibility #489

Closed
wants to merge 1 commit into from
Closed

PHPUnit 3.8 Compatibility #489

wants to merge 1 commit into from

Conversation

JoelMarcey
Copy link

PHPUnit 3.8+ adds a new method to PHPUnit_Framework_TestListener (addRiskyTest). Stub this out in places that need it so we can use PHPUnit 3.8+

PHPUnit 3.8 Compatibility
389668b 
Summary:

PHPUnit 3.8+ adds a new method to PHPUnit_Framework_TestListener (addRiskyTest). Stub this out in places that need it so we can use PHPUnit 3.8+

Test Plan:

Reviewers:

CC:

Task ID: #

Blame Rev:
@verklov verklov self-assigned this Feb 14, 2014
@verklov
Copy link
Contributor

verklov commented Feb 14, 2014

@JoelMarcey , thank you for your suggestion! We will think it over and let you know once we have a decision.

@verklov
Copy link
Contributor

verklov commented Feb 19, 2014

@JoelMarcey , we are using only stable versions of components. PHPUnit version 3.8 is not yet in a stable state. Thus, so far we will continue using PHPUnit version 3.7 (3.7.28). We will consider using PHPUnit 3.8 once it becomes stable. We are closing this issue so far.

@verklov verklov closed this Feb 19, 2014
@JoelMarcey
Copy link
Author

@verklov PHPUnit 3.8 (actually, it has been re-versioned as 4.0) will become stable on March 17, 2014 (see blurb at http://phpunit.de/). So stability is coming very soon. Maybe as we approach that date, we can revisit this pull request?

Btw, just to make sure we are both on the same page here.... accepting this pull request does not require the use of PHPUnit 3.8 (4.0). It just help prepares you for when you do make the switch. You can continue to use 3.7.x indefinitely even with this request in your code.

@verklov verklov reopened this Apr 8, 2014
@verklov
Copy link
Contributor

verklov commented Apr 8, 2014

@JoelMarcey, you are right - PHPUnit version 4.0 is now in a stable state. We reopened your pull request and placed a ticket into the product backlog.

@JoelMarcey
Copy link
Author

@verklov Excellent! Thank you very much!

cc: @fredemmott, @ptarjan

magento-team added a commit that referenced this pull request May 5, 2014
@magento-team
2.0.0.0-dev76
964b46c 
* Pricing improvements:
  * Eliminated code duplication from templates and implemented new calculation models for the following modules:
     * ConfigurableProduct
     * Wishlist
     * Rss
     * ProductAlert
* JavaScript improvements:
  * Removed head.js usages from frontend
  * Removed head.js usages from adminhtml
* Themes update:
  * Plushe styles are removed, Plushe theme is now based on blank
* Fixed bugs:
  * Unable to place order with product that contains custom option 'file'
  * OnePageCheckout is not working if PayPal method is enabled to work via Payment Bridge
  * Impossible to reset password for admin user (incorrect reset password link in email)
  * Errors when deleting customer group specified as default one in the config
  * A number of essential buttons do not work and block other functionality in Internet Explorer 10
  * "Insert Widget" button is missing in Insert Widget popup while creating CMS page
  * Impossible to change status for rating in admin
  * System email templates are not loaded when user creates new email template
  * Billing Agreements tab displays during New Customer creation in admin panel
  * Images are not displayed in WYSIWYG when editing default pages
  * Error message "Asymmetric transaction rollback" when creating simple product with flat catalog product option enabled in config
  * Fatal error when trying to preview sample(type=link) or view link for download(type="link") for downloadable product
  * Customer is redirected to Home Page after adding new address during multiple address checkout if secure URLs are enabled for frontend in config
  * Impossible to select value in the State/Province field in the customer registration form when customer uses multiple address checkout
  * Manage Stock option is not editable when using mass action on several products in the admin panel
  * Category is not displayed in layered navigation block when Flat Catalog is enabled in config
* GitHub requests:
  * [#489] (#489) -- PHPUnit 4.0 Compatibility
  * [#535] (#535) -- Image management for products
* Framework improvements:
  * Covered Magento lib form elements with unit tests:
      * `lib/Magento/Framework/Data/Form/Element/AbstractElement.php`
      * `lib/Magento/Framework/Data/Form/Element/Button.php`
      * `lib/Magento/Framework/Data/Form/Element/Checkbox.php`
      * `lib/Magento/Framework/Data/Form/Element/CollectionFactory.php`
      * `lib/Magento/Framework/Data/Form/Element/Column.php`
      * `lib/Magento/Framework/Data/Form/Element/File.php`
      * `lib/Magento/Framework/Data/Form/Element/Hidden.php`
      * `lib/Magento/Framework/Data/Form/Element/Editablemultiselect.php`
      * `lib/Magento/Framework/Data/Form/Element/Factory.php`
      * `lib/Magento/Framework/Data/Form/Element/Image.php`
      * `lib/Magento/Framework/Data/Form/Element/Imagefile.php`
      * `lib/Magento/Framework/Data/Form/Element/Label.php`
      * `lib/Magento/Framework/Data/Form/Element/Link.php`
      * `lib/Magento/Framework/Data/Form/Element/Multiselect.php`
      * `lib/Magento/Framework/Data/Form/Element/Note.php`
      * `lib/Magento/Framework/Data/Form/Element/Obscure.php`
      * `lib/Magento/Framework/Data/Form/Element/Password.php`
      * `lib/Magento/Framework/Data/Form/Element/Radio.php`
      * `lib/Magento/Framework/Data/Form/Element/Reset.php`
      * `lib/Magento/Framework/Data/Form/Element/Submit.php`
      * `lib/Magento/Framework/Data/Form/Element/Text.php`
      * `lib/Magento/Framework/Data/Form/Element/Textarea.php`
@verklov
Copy link
Contributor

verklov commented May 19, 2014

@JoelMarcey, we have released the support of PHPUnit 4.0 in dev76. Thank you for your request! Looking forward for your new contributions and bug reports!

@verklov verklov closed this May 19, 2014
magento-team pushed a commit that referenced this pull request Jul 24, 2015
@slopukhov
Merge pull request #489 from magento-troll/MAGETWO-33507
3e132a3 
[Troll] Refactor CSS and JavaScript minification mechanism
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 16, 2019
@magento-engcom-team
ENGCOM-5606: magento#271 [My Account] Add support of Customer attribu…
2c39ba3 
…tes magento#489

 - Merge Pull Request magento/graphql-ce#489 from magento/graphql-ce:feature/271-Customer-Attributes-Validation
 - Merged commits:
   1. dba9800
   2. 7f6718d
   3. 3735e91
   4. 342675a
   5. e177801
   6. 9b5b0a1
   7. 9f1ba1a
   8. 670116c
   9. 40e2363
   10. d071027
   11. b4db736
   12. 4b7acdc
   13. 48f1891
   14. 3641627
   15. ef078b6
   16. 1c65121
   17. cc69055
   18. 7ee6a1a
   19. f358267
   20. eb48f44
   21. 2eb7c15
   22. 7ca7acc
   23. 1c30336
   24. 4382c3a
   25. da8d6ac
   26. 0b4c496
   27. 5ae0633
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 16, 2019
@lenaorobei
ENGCOM-5606: magento#271 [My Account] Add support of Customer attribu…
2d48fbc 
…tes magento#489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@verklov verklov

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelMarcey @verklov