Cookie Restriction Mode Overlay should not be cached by Varnish #6455 #9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…html to fix varnish caching issue magento#6455
|
@bka merged, thanks! |
|
@bka thank you for your contribution. Your Pull Request has been successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed user-dependend
isUserNotAllowSaveCookiecondition in notice.ptml to fix varnish caching issue #6455The proposed solution for this problem is that alertinfo container is always present in dom, no matter what cookie data the user has set, it should only depend on the setting if cookie restriction mode is enabled.
Fixed Issues (if relevant)
Manual testing scenarios
Follow steps in issue #6455