Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug linked product position not updated if product link already exists #9810

Merged

Conversation

jalogut
Copy link
Contributor

@jalogut jalogut commented May 31, 2017

Linked product position is not updated on product import if product link already exists. This pull requests fixes that issue by always updating the sorting position

Steps to reproduce

Log into Magento Admin and do the following

  1. Go to manage products and open a product
  2. Go to Related Products, Up-Sells, and Cross-Sells section and add a couple of related products
  3. Save product
  4. Go to System > Export and export all products
  5. Take the generated .csv file and edit the related products order on related_position column for that product.
  6. Go to System > Import and import the edited .csv file
    • Entity type = product
    • Import behaviour = add/update

Expected Result

Related products order is updated.

Actual Result

Related products order is ignored during import as the related products are already existing.

@okorshenko okorshenko self-assigned this Jun 5, 2017
@okorshenko okorshenko added this to the June 2017 milestone Jun 5, 2017
@okorshenko
Copy link
Contributor

@jalogut could you please provide more details about testing of this issue.
This pull request will be processed faster if you will provide step by step instruction how to reproduce it and test.

@jalogut
Copy link
Contributor Author

jalogut commented Jun 8, 2017

Hi @okorshenko ,

Sure, please find here a short description about how to reproduce the issue:

Steps to reproduce

Log into Magento Admin and do the following

  1. Go to manage products and open a product
  2. Go to Related Products, Up-Sells, and Cross-Sells section and add a couple of related products
  3. Save product
  4. Go to System > Export and export all products
  5. Take the generated .csv file and edit the related products order on related_position column for that product.
  6. Go to System > Import and import the edited .csv file
    • Entity type = product
    • Import behaviour = add/update

Expected Result

Related products order is updated.

Actual Result

Related products order is ignored during import as the related products are already existing.

@okorshenko
Copy link
Contributor

@jalogut thank you for provided information

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 9, 2017
@magento-team magento-team merged commit 065ab55 into magento:develop Jun 12, 2017
magento-team pushed a commit that referenced this pull request Jun 12, 2017
@jalogut jalogut deleted the fix-import-product-links-update-position branch July 25, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants