-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Page Builder column responsive styles break with CMS block in page #4044
Comments
Hi @justinconabree. Thank you for your report. Join Magento Community Engineering Slack and ask your questions in #github channel. |
@magento I am working on this |
Hi @justinconabree , As per retesting the issue we are not able to reproduce it and working fine. Followed steps to reproduce :
For recording follow the link : |
We waited for more than 14 days for update on this issue, hence we are closing it. Please feel free to reopen if you are still have any update on the same. |
@adobe export issue to JIRA project PWA as Story |
✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3286 is successfully created for this GitHub issue. |
As we have not received any update on this issue, hence we are closing it. |
Describe the bug
When a CMS page has columns with responsive styles, and also has a CMS block with colums, the responsive styles for the page are no longer treated. This is because the CMS Block has it's own styles which override the media styles for the page.
To reproduce
Steps to reproduce the behavior:
CMS Block setup
Page Setup
Expected behavior
Desktop and mobile styling/images should differ on the page's columns
Actual behavior
Images and min-height stays the same across all media
Possible solutions
PR incoming. Media styles override with the last style tag.
Note: Also requires #4028 otherwise columns don't work
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
pagebuilder
The text was updated successfully, but these errors were encountered: