Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with Page Builder responsive styles and CMS Blocks #4045

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

justinconabree
Copy link
Contributor

Description

Merging

Related Issue

Closes #4044

Acceptance

Verification Stakeholders

Specification

Requires https://github.com/magento/pwa-studio/pull/4028/files to be able to use columns in page builder

Verification Steps

Test scenario(s) for direct fix/feature

Preconditions

  1. Create a CMS block with columns
  2. Create a CMS Page with columns (with responsive styles) and CMS block

Testing

  1. Page should display differently between desktop and mobile

Is Browser/Device testing needed?

No device testing needed. Just change screen size between desktop/mobile.

Breaking Changes (if any)

None

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 23, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b27c46f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Page Builder column responsive styles break with CMS block in page
2 participants