[bugfix]: Do not cache create customer or sign in mutation data #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanth0212
previously approved these changes
Feb 19, 2020
sirugh
added
the
version: Patch
sirugh
changed the title
|
jimbo
previously approved these changes
Feb 19, 2020
davemacaulay
previously approved these changes
Feb 19, 2020
tjwiebell
previously approved these changes
Feb 19, 2020
tjwiebell
dismissed stale reviews from davemacaulay, jimbo, sirugh, revanth0212, and themself
via
f537d1c
davemacaulay
approved these changes
Feb 19, 2020
dpatil-magento
pushed a commit
that referenced
this pull request
Feb 19, 2020
* Do not cache create customer or sign in mutation data * Ensure shipping and guest email is not persisted in cache Co-authored-by: Tommy Wiebell <twiebell@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the create customer and sign in mutations to not cache. This way we don't keep PII around.
Related Issue
Closes PWA-380.
Acceptance
Verification Stakeholders
Specification
Verification Steps
ROOT_MUTATIONdoes not contain any PIIROOT_MUTATIONentry) does not contain PII from create customer mutationScreenshots / Screen Captures (if appropriate)
Checklist