Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
Merge pull request #32 from mageplaza/2.4-develop
Browse files Browse the repository at this point in the history
2.4 develop
  • Loading branch information
haitv282 authored Jul 13, 2022
2 parents 9433ac3 + b65b499 commit 1d16261
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Block/Popup.php
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public function checkExclude()
public function checkExcludePages()
{
$fullActionName = $this->getRequest()->getFullActionName();
$arrayPages = explode("\n", $this->_helperData->getWhereToShowConfig('exclude_pages'));
$arrayPages = explode("\n", $this->_helperData->getWhereToShowConfig('exclude_pages') ?: '');
$includePages = array_map('trim', $arrayPages);

return !in_array($fullActionName, $includePages, true);
Expand All @@ -233,7 +233,7 @@ public function checkExcludePaths()
$pathsUrl = array_map('trim', $arrayPaths);

foreach ($pathsUrl as $path) {
if (strpos($currentPath, $path) !== false) {
if (!empty($path) && strpos($currentPath, $path) !== false) {
return false;
}
}
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
"name": "mageplaza/module-better-popup",
"description": "Magento 2 Better Popup",
"require": {
"mageplaza/module-core": "^1.4.5",
"mageplaza/module-smtp": "^4.5.3"
"mageplaza/module-core": "^1.4.12",
"mageplaza/module-smtp": "^4.7.2"
},
"type": "magento2-module",
"version": "4.1.2",
"version": "4.1.3",
"license": "proprietary",
"authors": [
{
Expand Down

0 comments on commit 1d16261

Please sign in to comment.