Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket support #23

Merged

Conversation

meejah
Copy link
Member

@meejah meejah commented Apr 15, 2021

This builds on the new iosim.IOPump-based tests to add WebSocket support with proper tests.

Needs:

  • branch-coverage of tests in a few more places
  • there are two new_protocol_ws implementations; unify
  • possibly more cleanup
  • [ ]

@lgtm-com
Copy link

lgtm-com bot commented Apr 15, 2021

This pull request introduces 13 alerts when merging 141709b into de8e0f0 - view on LGTM.com

new alerts:

  • 5 for First parameter of a method is not named 'self'
  • 5 for Unused import
  • 1 for Use of the return value of a procedure
  • 1 for Non-callable called
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Apr 15, 2021

This pull request introduces 13 alerts when merging 553158d into de8e0f0 - view on LGTM.com

new alerts:

  • 5 for First parameter of a method is not named 'self'
  • 5 for Unused import
  • 1 for Use of the return value of a procedure
  • 1 for Non-callable called
  • 1 for Unreachable code

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #23 (6bd063a) into master (0de4f23) will increase coverage by 0.13%.
The diff coverage is 99.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   99.07%   99.21%   +0.13%     
==========================================
  Files           5        7       +2     
  Lines         326      512     +186     
  Branches       48       55       +7     
==========================================
+ Hits          323      508     +185     
  Misses          1        1              
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/wormhole_transit_relay/usage.py 98.68% <98.68%> (ø)
src/wormhole_transit_relay/server_state.py 99.43% <99.43%> (ø)
src/wormhole_transit_relay/server_tap.py 100.00% <100.00%> (ø)
src/wormhole_transit_relay/transit_server.py 100.00% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de4f23...6bd063a. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Apr 15, 2021

This pull request introduces 9 alerts when merging aa58b85 into 0de4f23 - view on LGTM.com

new alerts:

  • 5 for First parameter of a method is not named 'self'
  • 2 for Use of the return value of a procedure
  • 1 for Non-callable called
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Apr 19, 2021

This pull request introduces 9 alerts when merging 807dfc1 into 0de4f23 - view on LGTM.com

new alerts:

  • 5 for First parameter of a method is not named 'self'
  • 2 for Use of the return value of a procedure
  • 1 for Non-callable called
  • 1 for Unreachable code

Copy link

@vu3rdd vu3rdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one or two silly comments, overall looks really great. Automat based state machine looks very nice!

src/wormhole_transit_relay/usage.py Show resolved Hide resolved
client_protocol,
iosim.makeFakeClient(client_protocol),
)
return pump, client_protocol
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about iosim, so I only skimmed this part of the code and did not go deeply into iosim itself.

partner_connection_lost,
enter=done,
outputs=[],
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole state machine logic is very beautiful and so clear to read!

Copy link

@vu3rdd vu3rdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@meejah meejah merged commit 80e02d4 into magic-wormhole:master May 10, 2021
@meejah meejah deleted the websocket-support-on-iosim-tests-master branch May 10, 2021 05:49
@lgtm-com
Copy link

lgtm-com bot commented May 10, 2021

This pull request introduces 9 alerts when merging 6bd063a into 0de4f23 - view on LGTM.com

new alerts:

  • 5 for First parameter of a method is not named 'self'
  • 2 for Use of the return value of a procedure
  • 1 for Non-callable called
  • 1 for Unreachable code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants