Update export.php to conform to SOTA CSV standard #1748
Conversation
The SOTA Database CSV standard expects commas (",") to delimit fields; see https://www.sotadata.org.uk/en/upload/activator/csv/info. The export function currently uses semicolons (";"). Although the SOTA Database gracefully accepts semicolon-delimited CSV files, I propose to conform to the expectation and use comma delimiters.
Also fix a typo in "MICROWAVE".
|
Oh darn. Just realized that you made a separate PR for this... Just added your fixed to my PR #1747. Will revert. |
|
Thanks a lot! :) |
| ); | ||
| foreach ($qsos as $qso) { | ||
| $timestamp = strtotime($qso['COL_TIME_ON']); | ||
| print "V2;".$qso['station_callsign'].";".$qso['COL_MY_SOTA_REF'].";".date('d/m/y', $timestamp).";".date('Hi', $timestamp).";".$bands[$qso['COL_BAND']].";".$qso['COL_MODE'].";".$qso['COL_CALL'].";".$qso['COL_SOTA_REF'].";".$qso['COL_COMMENT']."\n"; | ||
| print "V2;".$qso['station_callsign'].",".$qso['COL_MY_SOTA_REF'].",".date('d/m/y', $timestamp).",".date('Hi', $timestamp).",".$bands[$qso['COL_BAND']].",".$qso['COL_MODE'].",".$qso['COL_CALL'].",".$qso['COL_SOTA_REF'].",".$qso['COL_COMMENT']."\n"; |
There was a problem hiding this comment.
Missed semicolon on V2;
|
This patch was applied to master branch by accident. So it was reverted by @magicbug and talking to him I recreated it against dev and also included @AndreasK79's issue from above. |
My apologies! I'm not experienced with Git(Hub), unfortunately. Thank you for clearing it up and merging the fix! :) |
No worries. Just wanted to explain what happened in case you wondered 😇 |
The SOTA Database CSV standard expects commas (",") to delimit fields; see https://www.sotadata.org.uk/en/upload/activator/csv/info. The export function currently uses semicolons (";"). Although the SOTA Database gracefully accepts semicolon-delimited CSV files, I propose to conform to the expectation and use comma delimiters.
Also fix a typo in "MICROWAVE".