Fix ADIF version tags #1840
Merged
Fix ADIF version tags #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasK79
reviewed
Dec 12, 2022
AndreasK79
reviewed
Dec 12, 2022
|
@phl0 I don't mind at all. Just need to remove version in strlen. |
|
Fixed the other files. Ready for merge. |
|
Tested adif-generating ok. Merge time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreasK79 had fixed one occurrence but there are more. Moreover I would like to propose not to include "version" in the version tag itself. Seems somewhat doubled :) Hope @AndreasK79 does not mind. If so I will apply his patch to the other places in the code.
Fixes #1837 and similar code parts.