[PHP8.1] Added some fixes for PHP 8.1

[AndreasK79]

Credits to @mattmelling. I found these on his fork.

Everything seems to work ok on my local test.

@phl0 mind testing on 8.1?

[mattmelling]

Sorry, should have submitted these changes upstream to you guys. Policy on changes to CodeIgniter is clearer now so will bear that in mind.

My fork is to support NixOS which updates quite quickly and php7 support was dropped in last month's release, hence the hacky changes.

[AndreasK79]

@mattmelling No worries. PR's are always welcome. Changes to CodeIgniter does make an upgrade more difficult, but as long as it fixes stuff...
Before the V2 release, I tested the latest CI 3 code base, but found that it didn't have the necessary fixes for 8.1, so I never bothered with an upgrade.

I did add an extra fix in profiler.php:496 compared to your fixes.

[phl0]

@phl0 mind testing on 8.1?

Sure: https://github.com/AndreasK79/Cloudlog/pull/15

[phl0]

Apart from that the big bunch of errors on top are now fixed. Previously it looked like this:

Those are gone now.

[AndreasK79]

Found a few places that doesn't work:

1. Analytics/statistics (Years/mode/bands)
2. CQ Map
3. DXCC Map
4. IOTA Map

They all fail with the same message:

<p>Severity: 8192</p>
<p>Message:  str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated</p>
<p>Filename: core/Output.php</p>
<p>Line Number: 457</p>

Edit: Fixed with replacing output.php from CI github repo.

[phl0]

Jepp. Also found some places. Will fix finding by finding.

[phl0]

Fix for the maps: https://github.com/AndreasK79/Cloudlog/pull/16

[AndreasK79]

Fix for the maps: AndreasK79#16

That is also one way to fix it. I fetched the updated file from the CI repo and pushed.

[AndreasK79]

@phl0 did you find any more places that PHP8.1 didn't work?

[phl0]

That is also one way to fix it. I fetched the updated file from the CI repo and pushed.

Ok I guess it also fixes the maps issue? If so I will just close my PR.

[AndreasK79]

@phl0 yes, it does. I thought you were looking into other stuff, sorry.

[phl0]

No worries. Still clicking myself through stuff.

[phl0]

Finished. The rest seems to work ok. But no guarantee :D

[phl0]

Just tested your 8.1 branch on my PHP 7.4.3 installation. No issues ;-)

[AndreasK79]

Thanks @phl0.

@magicbug wanna test before merge?

[magicbug]

seems OK to go into dev branch