Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shouldReturnURI to configuration #723

Merged
merged 15 commits into from
Dec 13, 2024

Conversation

mattupham
Copy link
Contributor

@mattupham mattupham commented Mar 6, 2024

📦 Pull Request

  • When trying to implement Magic's loginWithRedirect social login, the social providers won't display redirect in an iframe
  • We should return a URI optionally in this specific use case

🚨 Test instructions

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • minor: New Feature

Special Note

  • intended for indiviudal use
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/oauth2@9.20.0-canary.723.12288593855.0
# or 
yarn add @magic-ext/oauth2@9.20.0-canary.723.12288593855.0

@mattupham mattupham added the minor Increment the minor version when merged label Mar 6, 2024
@mattupham mattupham marked this pull request as draft March 6, 2024 17:50
@Ethella Ethella self-assigned this Jul 4, 2024
@Ethella Ethella marked this pull request as ready for review December 13, 2024 00:24
@Ethella Ethella requested a review from a team as a code owner December 13, 2024 00:24
@Ethella Ethella added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 9c1662c Dec 13, 2024
6 checks passed
@Ethella Ethella deleted the PDEEXP-530-wallet-connect-login-with-redirect branch December 13, 2024 00:31
@svc-magic-git svc-magic-git added the released This issue/pull request has been released. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants