add web3modal extension #742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcote
requested review from
bcleary06,
patjacobs-magic,
Ethella and
romin-halltari
Ethella
reviewed
May 16, 2024
Ethella
reviewed
Jul 22, 2024
Ethella
previously approved these changes
Jul 22, 2024
| }, | ||
| "devDependencies": { | ||
| "@magic-sdk/commons": "^24.0.2", | ||
| "@magic-sdk/types": "24.0.2-canary.742.9175925480.0" |
There was a problem hiding this comment.
is this canary version needed here?
There was a problem hiding this comment.
Because @magic-sdk/types is a separate package, which is getting updated types that this extension is using, we need @magic-sdk/types to be published. So I think yes we need to reference a canary version at least at the first publish, then we can update the extension to use a non-canary
romin-halltari
previously approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
Looks like a huge PR by the number of files modified, but they are mostly test files.
Changes summary
isConnectedto third party wallet state & rpc routing to walletsrequestfunction to route payload to third party wallet if connected✅ Fixed Issues
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.Special Note
Please avoid adding any of the
Prioritylabels as they conflict with the labels above ☝️📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @magic-ext/algorand@23.2.1-canary.742.10067162636.0 npm install @magic-ext/aptos@11.2.1-canary.742.10067162636.0 npm install @magic-ext/avalanche@23.2.1-canary.742.10067162636.0 npm install @magic-ext/bitcoin@23.2.1-canary.742.10067162636.0 npm install @magic-ext/conflux@21.2.1-canary.742.10067162636.0 npm install @magic-ext/cosmos@23.2.1-canary.742.10067162636.0 npm install @magic-ext/ed25519@19.2.1-canary.742.10067162636.0 npm install @magic-ext/farcaster@0.2.2-canary.742.10067162636.0 npm install @magic-ext/flow@23.2.1-canary.742.10067162636.0 npm install @magic-ext/gdkms@11.2.1-canary.742.10067162636.0 npm install @magic-ext/harmony@23.2.1-canary.742.10067162636.0 npm install @magic-ext/icon@23.2.1-canary.742.10067162636.0 npm install @magic-ext/near@23.2.1-canary.742.10067162636.0 npm install @magic-ext/oauth@22.2.1-canary.742.10067162636.0 npm install @magic-ext/oauth2@9.2.1-canary.742.10067162636.0 npm install @magic-ext/oidc@11.2.1-canary.742.10067162636.0 npm install @magic-ext/polkadot@23.2.1-canary.742.10067162636.0 npm install @magic-ext/react-native-bare-oauth@25.2.1-canary.742.10067162636.0 npm install @magic-ext/react-native-expo-oauth@25.2.1-canary.742.10067162636.0 npm install @magic-ext/solana@25.3.1-canary.742.10067162636.0 npm install @magic-ext/sui@0.3.1-canary.742.10067162636.0 npm install @magic-ext/taquito@20.2.1-canary.742.10067162636.0 npm install @magic-ext/terra@20.2.1-canary.742.10067162636.0 npm install @magic-ext/tezos@23.2.1-canary.742.10067162636.0 npm install @magic-ext/web3modal-ethers5@0.1.1-canary.742.10067162636.0 npm install @magic-ext/webauthn@22.2.1-canary.742.10067162636.0 npm install @magic-ext/zilliqa@23.2.1-canary.742.10067162636.0 npm install @magic-sdk/commons@24.2.1-canary.742.10067162636.0 npm install @magic-sdk/pnp@22.2.1-canary.742.10067162636.0 npm install @magic-sdk/provider@28.2.1-canary.742.10067162636.0 npm install @magic-sdk/react-native-bare@29.2.1-canary.742.10067162636.0 npm install @magic-sdk/react-native-expo@29.2.1-canary.742.10067162636.0 npm install @magic-sdk/types@24.0.6-canary.742.10067162636.0 npm install magic-sdk@28.2.1-canary.742.10067162636.0 # or yarn add @magic-ext/algorand@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/aptos@11.2.1-canary.742.10067162636.0 yarn add @magic-ext/avalanche@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/bitcoin@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/conflux@21.2.1-canary.742.10067162636.0 yarn add @magic-ext/cosmos@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/ed25519@19.2.1-canary.742.10067162636.0 yarn add @magic-ext/farcaster@0.2.2-canary.742.10067162636.0 yarn add @magic-ext/flow@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/gdkms@11.2.1-canary.742.10067162636.0 yarn add @magic-ext/harmony@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/icon@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/near@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/oauth@22.2.1-canary.742.10067162636.0 yarn add @magic-ext/oauth2@9.2.1-canary.742.10067162636.0 yarn add @magic-ext/oidc@11.2.1-canary.742.10067162636.0 yarn add @magic-ext/polkadot@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/react-native-bare-oauth@25.2.1-canary.742.10067162636.0 yarn add @magic-ext/react-native-expo-oauth@25.2.1-canary.742.10067162636.0 yarn add @magic-ext/solana@25.3.1-canary.742.10067162636.0 yarn add @magic-ext/sui@0.3.1-canary.742.10067162636.0 yarn add @magic-ext/taquito@20.2.1-canary.742.10067162636.0 yarn add @magic-ext/terra@20.2.1-canary.742.10067162636.0 yarn add @magic-ext/tezos@23.2.1-canary.742.10067162636.0 yarn add @magic-ext/web3modal-ethers5@0.1.1-canary.742.10067162636.0 yarn add @magic-ext/webauthn@22.2.1-canary.742.10067162636.0 yarn add @magic-ext/zilliqa@23.2.1-canary.742.10067162636.0 yarn add @magic-sdk/commons@24.2.1-canary.742.10067162636.0 yarn add @magic-sdk/pnp@22.2.1-canary.742.10067162636.0 yarn add @magic-sdk/provider@28.2.1-canary.742.10067162636.0 yarn add @magic-sdk/react-native-bare@29.2.1-canary.742.10067162636.0 yarn add @magic-sdk/react-native-expo@29.2.1-canary.742.10067162636.0 yarn add @magic-sdk/types@24.0.6-canary.742.10067162636.0 yarn add magic-sdk@28.2.1-canary.742.10067162636.0