Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eslint version #834

Merged
merged 14 commits into from
Nov 26, 2024

Conversation

otabek-magic
Copy link
Contributor

πŸ“¦ Pull Request

https://magiclink.atlassian.net/browse/PDEEXP-1985

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

Copy link

swarmia bot commented Nov 12, 2024

βœ… Β Linked to Task PDEEXP-1985 Β· Bump magic-sdk eslint version to 9
➑️  Part of Epic PDEEXP-1252 · General Tech Debt

@otabek-magic otabek-magic marked this pull request as ready for review November 13, 2024 16:27
@Ethella Ethella added the skip-release Preserve the current version when merged label Nov 15, 2024
@Ethella Ethella self-assigned this Nov 15, 2024
@Ethella
Copy link
Member

Ethella commented Nov 15, 2024

I got this error when I try to run yarn lint

 | (node:97844) ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
 | (Use `node --trace-warnings ...` to show where the warning was created)
 | 
 | Oops! Something went wrong! :(
 | 
 | ESLint: 9.14.0
 | 
 | ESLint couldn't find an eslint.config.(js|mjs|cjs) file.
 | 
 | From ESLint v9.0.0, the default configuration file is now eslint.config.js.

Could you make sure it work with command?

@Ethella
Copy link
Member

Ethella commented Nov 19, 2024

Changes look good to me. Could you fix the tests and linter from the CI?

@Ethella
Copy link
Member

Ethella commented Nov 25, 2024

image
There're a few warnings here, add "no-redeclare": "off", to the config

@Ethella Ethella merged commit 282932f into master Nov 26, 2024
5 of 6 checks passed
@Ethella Ethella deleted the PDEEXP-1985-bump-magic-sdk-eslint-version-to-9 branch November 26, 2024 17:21
@svc-magic-git svc-magic-git added the released This issue/pull request has been released. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants