-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump eslint version #834
Merged
Ethella
merged 14 commits into
master
from
PDEEXP-1985-bump-magic-sdk-eslint-version-to-9
Nov 26, 2024
Merged
chore: bump eslint version #834
Ethella
merged 14 commits into
master
from
PDEEXP-1985-bump-magic-sdk-eslint-version-to-9
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β
Β Linked to Task PDEEXP-1985 Β· Bump magic-sdk eslint version to 9 |
I got this error when I try to run
Could you make sure it work with command? |
β¦ub.com:magiclabs/magic-js into PDEEXP-1985-bump-magic-sdk-eslint-version-to-9
Changes look good to me. Could you fix the tests and linter from the CI? |
Ethella
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
released
This issue/pull request has been released.
skip-release
Preserve the current version when merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Pull Request
https://magiclink.atlassian.net/browse/PDEEXP-1985
β Fixed Issues
π¨ Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please π¨ ONLY ADD ONE π¨ of the following labels, failing to do so may lead to adverse versioning of your changes when published:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.Special Note
Please avoid adding any of the
Priority
labels as they conflict with the labels above βοΈ