Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display inline images in topics #47

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Conversation

vermiculus
Copy link
Contributor

@vermiculus vermiculus commented Dec 29, 2018

Implement the view-parts of #41.

This is still something of a proof-of-concept and is dependent on jrblevin/markdown-mode#378. Make sure you set markdown-display-remote-images to t (it could be let-bound to a Forge-customization here) and that all appropriate protocols have been added to markdown-remote-image-protocols.

@vermiculus
Copy link
Contributor Author

vermiculus commented Dec 29, 2018

From #41 (comment)

Lets see if using ![about](https://EXTERN) actually works:

Funnily enough, this is causing an error. Don't know why EXTERN is being caught here – probably being caught as real markdown even though it's in a code-block. I think it might have something to do with hiding markup, but both markdown-hide-markup and markdown-hide-markup-in-view-modes are nil.

Your note about overlays not being copied may be relevant here.

@tarsius
Copy link
Member

tarsius commented Feb 18, 2019

Not sure why I haven't done anything about this for so long. It seems to work well for the most part.

(it could be let-bound to a Forge-customization here)

Done that in a fixup commit.

Funnily enough, this is causing an error.

But that's something that has to be addressed in markdown-mode, right? It would be nice if this would continue after failing to insert one image. (Or at least that's something worth considering).

Unless you see a reason to delay this, I'll merge it.

@vermiculus
Copy link
Contributor Author

Testing this since it's been a while… :-)

image

@vermiculus
Copy link
Contributor Author

vermiculus commented Feb 21, 2019

Once I took out ![about](https://EXTERN) from my post above, still works fine :) I see no reason for delay.

Looks like markdown-regex-link-inline needs to be adjusted to avoid matching `blocks`.

@tarsius tarsius merged commit cf4e524 into magit:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants