Bind RET to follow Markdown links in issue buffers

[Miciah]

• lisp/forge-topic.el (forge-topic-mode-map): Remap magit-visit-thing to markdown-follow-link-at-point.

[vermiculus]

Any way this keybind could be added to the link itself instead of everywhere? I can definitely imagine trying to RET on a user name or something.

[tarsius]

Yes, we cannot just bind this in forge-topic-mode-map. Doing it properly will probably be quite a bit of work. This also came up in #45.

[Miciah]

I almost went with a wrapper instead of binding markdown-follow-link-at-point directly, something like the following:

(defun forge-issue-visit-thing ()
  "Visit the current link using a browser."
  (interactive)
  (cond ((markdown-link-p)
         (markdown-follow-link-at-point))
        ((markdown-wiki-link-p)
         (markdown-follow-wiki-link-at-point))
        ;; TODO Handle @username and #123.
        (t (user-error "Nothing to follow at point"))))

In the end I went with bindingmarkdown-follow-link-at-point directly because refactoring is the easy part (compared to implementing the TODO), but I can amend my change to use the above function; please let me know if that would be an acceptable starting point.

Another option would be to scan for properties or regexes for Markdown links and using make-text-button or similar to linkify them. Please let me know if you would be interested in that approach.

[tarsius]

I'm undecided. Reopening to keep track of this.

[tarsius]

Another option would be to scan for properties or regexes for Markdown links and using make-text-button or similar to linkify them. Please let me know if you would be interested in that approach.

I think we should use this approach.