tab widget visibility

magland · Apr 26, 2024 · ad751f7 · ad751f7
1 parent 5391640
commit ad751f7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/gui/src/libraries/core-views/component-tab-widget/TabWidget.tsx b/gui/src/libraries/core-views/component-tab-widget/TabWidget.tsx
@@ -39,7 +39,7 @@ const TabWidget: FunctionComponent<PropsWithChildren<Props>> = ({children, tabs,
                 children2.map((c, i) => {
                     const visible = i === currentTabIndex
                     return (
-                        <div key={`child-${i}`} style={{visibility: visible ? 'visible' : 'hidden', overflowY: 'hidden', overflowX: 'hidden', position: 'absolute', left: 0, top: tabBarHeight, width: W, height: H}}>
+                        <div key={`child-${i}`} style={{visibility: visible ? undefined : 'hidden', overflowY: 'hidden', overflowX: 'hidden', position: 'absolute', left: 0, top: tabBarHeight, width: W, height: H}}>
                             <c.type {...c.props} width={W} height={H - tabBarHeight}/>
                         </div>
                     )

diff --git a/gui/src/libraries/spike-sorting-views/context-sorting-curation/SortingCurationContext.ts b/gui/src/libraries/spike-sorting-views/context-sorting-curation/SortingCurationContext.ts
@@ -27,7 +27,7 @@ export const sortingCurationReducer = (state: SortingCuration, action: SortingCu
         const uids: (number | string)[] = typeof(action.unitId) === 'object' ? action.unitId : [action.unitId]
         const newLabelsByUnit = {...(state.labelsByUnit || {})}
         let somethingChanged = false
-        for (let uid of uids) {
+        for (const uid of uids) {
             const labels = newLabelsByUnit[uid + ''] || []
             if (!labels.includes(action.label)) {
                 somethingChanged = true
@@ -62,7 +62,7 @@ export const sortingCurationReducer = (state: SortingCuration, action: SortingCu
         const uids: (number | string)[] = typeof(action.unitId) === 'object' ? action.unitId : [action.unitId]
         const newLabelsByUnit = {...(state.labelsByUnit || {})}
         let somethingChanged = false
-        for (let uid of uids) {
+        for (const uid of uids) {
             const labels = newLabelsByUnit[uid + ''] || []
             if (labels.includes(action.label)) {
                 somethingChanged = true

diff --git a/gui/src/libraries/spike-sorting-views/view-sorting-curation-2/SortingCuration2View.tsx b/gui/src/libraries/spike-sorting-views/view-sorting-curation-2/SortingCuration2View.tsx
@@ -42,14 +42,14 @@ const SortingCuration2View: FunctionComponent<Props> = ({data, width, height}) =
             if ((cbState === 'unchecked') || (cbState === 'indeterminant')) {
                 sortingCurationDispatch({
                     type: 'ADD_UNIT_LABEL',
-                    unitId: selectedUnitIds,
+                    unitId: [...selectedUnitIds],
                     label
                 })
             }
             else if (cbState === 'checked') {
                 sortingCurationDispatch({
                     type: 'REMOVE_UNIT_LABEL',
-                    unitId: selectedUnitIds,
+                    unitId: [...selectedUnitIds],
                     label
                 })
             }

diff --git a/gui/src/libraries/spike-sorting-views/view-unit-metrics-graph/UnitMetricScatterPlot.tsx b/gui/src/libraries/spike-sorting-views/view-unit-metrics-graph/UnitMetricScatterPlot.tsx
@@ -21,7 +21,7 @@ const UnitMetricScatterPlot: FunctionComponent<UnitMetricScatterPlotProps> = ({m
     const radius = 6
     const markers: ScatterPlotMarker[] = useMemo(() => {
         const ret: ScatterPlotMarker[] = []
-        for (let unit of units) {
+        for (const unit of units) {
             const xValue = unit.values[metric1.key]
             const yValue = unit.values[metric2.key]
             if ((xValue !== undefined) && (yValue !== undefined)) {