Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): nms yarn test filed #15217

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

prabinakpattnaik
Copy link
Contributor

Summary

It's failing on latest CI/CD check and getting below errors:

Summary of all failing tests
FAIL app/views/traffic/__tests__/TrafficOverviewTest.tsx (8.891 s)
  ● <TrafficDashboard APNs/> › renders

    TypeError: Cannot redefine property: location

      319 |
      320 |   beforeEach((): void => {
    > 321 |     window.location = {
          |     ^
      322 |       pathname: '/nms/test/traffic/apn',
      323 |     } as Location;
      324 |

      at Object.<anonymous> (app/views/traffic/__tests__/TrafficOverviewTest.tsx:321:5)

Test Plan

CI/CD run

@prabinakpattnaik prabinakpattnaik requested a review from a team as a code owner June 19, 2023 08:19
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 19, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Jun 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit aa3f16c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

NMS Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ebe2b50.

♻️ This comment has been updated with latest results.

@maxhbr
Copy link
Member

maxhbr commented Jun 19, 2023

this seems to be an accepted solution in jestjs/jest#5124

Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>
Signed-off-by: prabina pattnaik <prabinak@wavelabs.ai>
@panyogesh panyogesh merged commit 4b5d492 into magma:master Jul 29, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants