Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves readability of floor numbers and makes better use of space in the "waiting area". #73

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mrap
Copy link

@mrap mrap commented Feb 5, 2015

screenshot

@magwo
Copy link
Owner

magwo commented Feb 5, 2015

Nice! However, I don't like how users will spawn on top of the floor number, and that they will "fly" past the floor number when they get on an elevator.

Any specific reason that the floor number is lower right? Otherwise I suggest moving it to the left again.

@mrap
Copy link
Author

mrap commented Feb 5, 2015

Main reason for floor numbers on the right side: much closer to the elevators which are in constant flux. It makes tracking/comparing elevators with the floor's arrow indicators much easier. The main drawback, as you've stated, is users can appear over the floor numbers. But those numbers are constant, motionless, and large.

Although, I don't like that users can appear above floor numbers either. Maybe we can place the .floor-info at a higher z-index? Or even increase the background darkness?

@magwo
Copy link
Owner

magwo commented Feb 7, 2015

Nah, maybe it's not a big deal. Can experiment with it later. I wouldn't want the floor number to have higher z than passengers, as I imagine the floor number is written on the wall of each floor.

@mrap
Copy link
Author

mrap commented Feb 8, 2015

Another idea is to shorten the waiting area width so that users don't wait on top of the floor number. The only time they'd cover it is when they pass it on the way to an elevator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants