Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO formatted time #6

Open
envilogger opened this issue Dec 20, 2015 · 1 comment
Open

ISO formatted time #6

envilogger opened this issue Dec 20, 2015 · 1 comment

Comments

@envilogger
Copy link

Hi

I found that you're using toLocaleTimeString() method to write timestamp
It might cause problems in some cases (ie if different locale is set on different environments and local developers machine)
So, for example, if locale is set to en-us timestamp looks like 4:32:46 PM.765
I think it's better to use ISO formatted time, ie 16:32:46.765
envilogger added a commit to envilogger/mag-fallback that referenced this issue Dec 20, 2015
@envilogger
change timestamp format to ISO
b76204b 
according to mahnunchik/mag#6
This was referenced Dec 20, 2015
Open
Merged
@mahnunchik
Copy link
Owner

Hi @envilogger

Yes, using toLocaleTimeString method isn't good idea.
But for mag-fallback module I think it will be enough to have only time in the message. I will try to implement it using getUTC* methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahnunchik @envilogger