Revert "feat(antctl): impl network_id option while adding node" #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -537,6 +567,8 @@ | |||
| "10", | |||
| "--max-log-files", | |||
| "10", | |||
| "--peer", | |||
| "/ip4/127.0.0.1/tcp/8080,/ip4/192.168.1.1/tcp/8081", | |||
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| @@ -98,44 +54,42 @@ | |||
| } | |||
| } | |||
|
|
|||
| /// FIXME: Remove this once BEFORE next breaking release and fix this whole file | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
jacderida
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #2508
Revert #2503
These have to merged back in later.