Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to JQueryUI Compat activated. #1034

Closed
webtekindo opened this issue Aug 6, 2020 · 1 comment
Closed

Fallback to JQueryUI Compat activated. #1034

webtekindo opened this issue Aug 6, 2020 · 1 comment
Assignees
@gonzaloebiz
Labels
bug Magento 2.1 Magento 2.2 Magento 2.3
Milestone
10x.x.41

Comments

@webtekindo
Copy link

In vendor/mailchimp/mc-magento2/view/frontend/web/js/campaigncatcher.js

There's dependency to 'jquery/ui'

That will produce a warning/error on frontend as it's not recommended:

Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site.

The dependency can be safely removed.
@Quazz
Copy link

Quazz commented Aug 7, 2020

Relevant PR #997

gonzaloebiz added a commit that referenced this issue Aug 27, 2020
@gonzaloebiz
the ui is unnecessary closes #1034 for magento 2.2
1af6bbe
gonzaloebiz added a commit that referenced this issue Aug 27, 2020
@gonzaloebiz
the ui is unnecessary closes #1034 for magento 2.1
0ea3101
@gonzaloebiz gonzaloebiz self-assigned this Aug 27, 2020
@gonzaloebiz gonzaloebiz added this to the 10x.x.41 milestone Aug 27, 2020
gonzaloebiz added a commit that referenced this issue Aug 27, 2020
@gonzaloebiz
Merge pull request #1040 from mailchimp/Issue1034-2.3
55786c6 
the ui is unnecessary closes #1034 for magento 2.3
gonzaloebiz added a commit that referenced this issue Aug 27, 2020
@gonzaloebiz
Merge pull request #1041 from mailchimp/Issue1034-2.2
729c2d9 
the ui is unnecessary closes #1034 for magento 2.2
gonzaloebiz added a commit that referenced this issue Aug 27, 2020
@gonzaloebiz
Merge pull request #1042 from mailchimp/Issue1034-2.1
50ca2ee 
the ui is unnecessary closes #1034 for magento 2.1
@gonzaloebiz gonzaloebiz mentioned this issue Aug 27, 2020
Closed
@gonzaloebiz gonzaloebiz mentioned this issue Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonzaloebiz gonzaloebiz

Labels
bug Magento 2.1 Magento 2.2 Magento 2.3
Projects
None yet
Milestone
10x.x.41
Development

No branches or pull requests
3 participants
@Quazz @gonzaloebiz @webtekindo