Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code in Heper/Data.php #1753

Closed
gonzaloebiz opened this issue Jul 19, 2023 · 0 comments · Fixed by #1754
Closed

Remove unused code in Heper/Data.php #1753

gonzaloebiz opened this issue Jul 19, 2023 · 0 comments · Fixed by #1754
Assignees
@gonzaloebiz
Labels
enhancement Magento 2.4
Milestone
10x.x.54

Comments

@gonzaloebiz
Copy link
Collaborator

Issue Description

When move the functions for ecommetce to Helper/Sync.php 2 functions not deleted from Helper/Data.php (resyncAllSubscribers and resyncProducts)
@gonzaloebiz gonzaloebiz added this to the 10x.x.54 milestone Jul 19, 2023
@gonzaloebiz gonzaloebiz self-assigned this Jul 19, 2023
gonzaloebiz added a commit that referenced this issue Jul 19, 2023
@gonzaloebiz
closes #1753 for magento 2.4
fb67511
@gonzaloebiz gonzaloebiz linked a pull request Jul 19, 2023 that will close this issue
closes #1753 for magento 2.4 #1754
Merged
gonzaloebiz added a commit that referenced this issue Jul 19, 2023
@gonzaloebiz
Merge pull request #1754 from mailchimp/Issue1753-2.4
b0250fa 
closes #1753 for magento 2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonzaloebiz gonzaloebiz

Labels
enhancement Magento 2.4
Projects
None yet
Milestone
10x.x.54
Development

Successfully merging a pull request may close this issue.

closes #1753 for magento 2.4 mailchimp/mc-magento2
1 participant
@gonzaloebiz