Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance Issue] HTTP calls to mailchimp on every page request and config cache flush #939

Closed
IvanChepurnyi opened this issue Dec 17, 2019 · 2 comments

Comments

@IvanChepurnyi
Copy link

The module does HTTP calls on every page when the extension is just installed and not yet all JS URLs are fetched. The code behind a problem is this helper method.

This URL retrieval for JS should have been done via cronjob and storing URL should be done in an own database table. Updating store configuration triggers a complete configuration rebuild that results in a disaster under high load.

Preconditions

  1. Clean Magento 2.3.3
  2. Recent Mailchimp extension version installed but not configured
  3. Blackfire code profiler installed and configured

Steps to reproduce

  1. Profile any page with Blackfire
  2. Open generated profile and check the call stack of the mentioned method

Expected result

  • No HTTP calls
  • No updates to core_config_data

Actual results

  • HTTP call to Mailchimp API
  • Complete wipe-out of configuration cache on the frontend
@IvanChepurnyi IvanChepurnyi changed the title [Performance Isusse] HTTP calls to mailchimp on every page request and config cache flush [Performance Issue] HTTP calls to mailchimp on every page request and config cache flush Dec 17, 2019
@gonzaloebiz
Copy link
Collaborator

Hi @IvanChepurnyi

thanks for your feedback.
Please take a look at #891 this is already fixed and will be available on next release

Best

@IvanChepurnyi
Copy link
Author

The mentioned pull request does not address main issue with configuration cache wipe out on frontend and update of core_config_data table.

@gonzaloebiz gonzaloebiz self-assigned this Dec 26, 2019
@gonzaloebiz gonzaloebiz reopened this Dec 26, 2019
@gonzaloebiz gonzaloebiz added this to the 10x.x.38 milestone Dec 26, 2019
gonzaloebiz added a commit that referenced this issue Dec 27, 2019
gonzaloebiz added a commit that referenced this issue Dec 27, 2019
gonzaloebiz added a commit that referenced this issue Dec 27, 2019
gonzaloebiz added a commit that referenced this issue Dec 27, 2019
gonzaloebiz added a commit that referenced this issue Dec 27, 2019
gonzaloebiz added a commit that referenced this issue Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants