Change cron group id to 'mailchimp'. #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the cron group id to 'mailchimp', so it can be specifically addressed or excluded when running the `magento/bin cron:run` command via adding the option `--group mailchimp`. This wouldn't make much of difference for the general Magento 2 stores, because they keep running the cron:run command without any options, so all cron jobs are handled anyway including the mailchimp cron jobs, but for larger stores, which run long and extensive daily crons in the night, it could make a difference. E.g. we disable the normal cron process during the daily cron, which is run in the night, because otherwise certain processes would mingled which each other causing them to fail. Having separate cron group ids, would enable us to specifiy explicitly, which cron jobs can still be run or should be excluded in a simple way, without having to mingle to much with the Magento core code by creating Plugins, Observers or Preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the cron group id to 'mailchimp', so it can be specifically addressed or excluded when running the
magento/bin cron:runcommand via adding the option--group mailchimp.This wouldn't make much of difference for the general Magento 2 stores, because they keep running the cron:run command without any options, so all cron jobs are handled anyway including the mailchimp cron jobs, but for larger stores, which run long and extensive daily crons in the night, it could make a difference.
E.g. we disable the normal cron process during the daily cron, which is run in the night, because otherwise certain processes would mingled which each other causing them to fail. Having separate cron group ids, would enable us to specifiy explicitly, which cron jobs can still be run or should be excluded in a simple way, without having to mingle to much with the Magento core code by creating Plugins, Observers or Preferences.