Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant dependencies #9

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Remove redundant dependencies #9

merged 7 commits into from
Sep 30, 2024

Conversation

vtopc
Copy link
Contributor

@vtopc vtopc commented Sep 27, 2024

  • github.com/stretchr/testify/assert has a method to check if a slice contains the value.
  • logrus wouldn't be present in indirect dependencies

@vtopc vtopc changed the title Removed redundant dependency Remove redundant dependency Sep 27, 2024
@vtopc vtopc marked this pull request as ready for review September 27, 2024 09:45
Comment on lines -35 to +36
assert.Contains(t, fmt.Sprintf("%+v", stack), "errors/stack_test.go:18")
assert.Contains(t, fmt.Sprintf("%+v", stack), "errors/stack_test.go:17")
assert.Equal(t, "errors_test.TestWrapWithFieldsAndStack", caller.Func)
assert.Equal(t, 18, caller.LineNo)
assert.Equal(t, 17, caller.LineNo)
Copy link
Contributor Author

@vtopc vtopc Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed one line, so this should be shifted.

@vtopc vtopc requested a review from a team September 27, 2024 10:22
@vtopc vtopc changed the title Remove redundant dependency Remove redundant dependencies Sep 27, 2024
Copy link

@medge-mailgun medge-mailgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got to my reviews before I could submit them 😆 💪

@vtopc vtopc merged commit d5959e0 into main Sep 30, 2024
2 checks passed
@vtopc vtopc deleted the vtopc/remove-redundant branch September 30, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants