Add route to HealthCheck (useful in deployments to GKE) #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julliano Goncalves <jullianow@gmail.com>
jullianow
force-pushed
the
route_healthcheck
branch
from
3fcccab
to
0835a91
Compare
|
ping |
|
@tyndyll Can you help me with this? Also, you can tell how the project is progressing. Is it still in the process of evolution? |
|
Ping. |
|
Is this project dead? I see no recent activity. I'm tagging the last person committed to this repo: @tyndyll. |
|
@gedge ping |
fabio-andre-rodrigues
approved these changes
Mar 30, 2023
|
@fabio-andre-rodrigues Thank you for approving this PR. I'm looking forward to this being released in a version of Mailhog. |
|
It's now Mar 27th 2024 - any updates on when this'll be merged in ? |
|
I have the impression that this project is discontinued |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to provide a route for checking the life of the service.
This is extremely useful when the service is being deployed to GKE using GCE Ingress control.
This was an open discussion and seen as a limitation in the service's helm graph, as can be seen here: codecentric/helm-charts#627
Basically, when the service is configured with basic authentication, there is no route that returns Http code
2xx, so the Ingress-GCE life check cannot validate that the HTTP port exposed by the service (8025) is working correctly. .Signed-off-by: Julliano Goncalves jullianow@gmail.com