Feature/mem cache store #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add compatibility with mem_cache_store * Do not define multiple hooks in the same example group. * Gem / dependencies should be sorted in an alphabetical order.
- When the cache implementation does not implement `delete_matched` (e.g. memcached), clear all the possibly existing cache keys - Update the specs to test this case properly - Add the `dalli` gem for testing with the Memcached cache backend
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=========================================
+ Coverage 96.87% 96.9% +0.03%
=========================================
Files 33 33
Lines 703 710 +7
=========================================
+ Hits 681 688 +7
Misses 22 22
Continue to review full report at Codecov.
|
Do not pass the translation_set_id for the translations creation because they are already created through the translation set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #17 - Originally by @armandfardeau
This module is an excellent contribution to the Decidim universe, unfortunately, it was incompatible with mem_cache_store that we use in production. Feel free to do a review if something is not crystal clear, or not good.