Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in Dalli #82

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreslucena
Copy link
Contributor

There were these kinds of warnings when running the specs:

DEPRECATION: :dalli_store will be removed in Dalli 3.0.
Please use Rails' official :mem_cache_store instead.
https://guides.rubyonrails.org/caching_with_rails.html

This PR fixes them.

There were these kinds of warnings when running the specs:

> DEPRECATION: :dalli_store will be removed in Dalli 3.0.
> Please use Rails' official :mem_cache_store instead.
> https://guides.rubyonrails.org/caching_with_rails.html
@ahukkanen
Copy link
Collaborator

Thanks @andreslucena !

There is already tests for the memcached store, so if you want to remove the DalliStore tests, could you remove the whole context?

Could you also rebase this PR against the develop branch?

@ahukkanen ahukkanen marked this pull request as draft May 13, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants