Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so there was an announcement a while ago that all GitHub actions would use Node 14 but it turns out that was a bit of a misleading announcement. That only applies for the environment that the actions are run in but not the actions themselves 🤦
There is an open issue requesting that actions have the ability to run in Node 14 that seems to be blocked for some reason.
Long story short: I was a bit preemptive removing the use of esm from ember-asset-size-action since we can't make use of native esm modules just yet 😞
Edit: turns out that mocha 9 doesn't work in this setup because it is enabling partial esm support even though you need the flag for that to work correctly 🙃