Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset back to using esm #28

Merged
merged 4 commits into from
Jun 14, 2021
Merged

reset back to using esm #28

merged 4 commits into from
Jun 14, 2021

Conversation

mansona
Copy link
Member

@mansona mansona commented Jun 13, 2021

so there was an announcement a while ago that all GitHub actions would use Node 14 but it turns out that was a bit of a misleading announcement. That only applies for the environment that the actions are run in but not the actions themselves 🤦

There is an open issue requesting that actions have the ability to run in Node 14 that seems to be blocked for some reason.

Long story short: I was a bit preemptive removing the use of esm from ember-asset-size-action since we can't make use of native esm modules just yet 😞

Edit: turns out that mocha 9 doesn't work in this setup because it is enabling partial esm support even though you need the flag for that to work correctly 🙃

@mansona mansona requested review from a team and removed request for a team June 14, 2021 08:38
@mansona mansona merged commit 74a6f0c into master Jun 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the use-esm branch June 14, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants