Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session-stores/cookie: Convert private volatile properties to methods #1886

Merged
merged 1 commit into from
Jul 11, 2019
Merged

session-stores/cookie: Convert private volatile properties to methods #1886

merged 1 commit into from
Jul 11, 2019

Commits on Jul 5, 2019

  1. session-stores/cookie: Convert private volatile properties to methods 

    Using native getters would work too, but only in some newer versions of Ember. Older versions will have `this` assigned to the wrong thing and are not able to access `this.get` due to that. Using a regular method should work fine though and since these properties are private we can change the signature without it having to be a breaking change.
    @Turbo87
    Turbo87 committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    91b7c99 View commit details
    Browse the repository at this point in the history