Fix HBS transforms for Ember 1.11/1.12

[Turbo87]

This PR also reenables the actual attribute stripping transform which was apparently disabled by mistake in #150.

/cc @pzuraq @marcoow @geekygrappler

[pzuraq]

The attribute stripping transform wasn’t a mistake, it also breaks in certain templates in 1.11

[Turbo87]

@pzuraq if you disable the attribute stripping too then why use the addon at all?!

[pzuraq]

It still does reopen the component class to add data-test attributes, which is pretty useful

[Turbo87]

it also breaks in certain templates in 1.11

what kind of templates? I need a test case, otherwise I can't fix it.

[pzuraq]

In our app I believe the failure was caused by the link-to helper. My worry is that there will be more edge cases over time, however, which is why I opted to turn off the transforms altogether. We still get component’s being reopened, which allows us to move forward to 1.13 and get the full benefits of the transforms. Basically, regressed performance if you use old enough Ember.

[Turbo87]

In our app I believe the failure was caused by the link-to helper. My worry is that there will be more edge cases over time, however, which is why I opted to turn off the transforms altogether.

I'm happy to fix those issues if possible, but without any reproduction I can't.

Since the test cases that we currently have seems to work fine I'd prefer to merge it like this. If you don't want to use the positional to hash params function then you can just ignore it and always use hash params. And if the stripping transform fails it will be the same as if the transform would be disabled completely.

[pzuraq]

The stripping transform errors, which causes builds to break IIRC. If you’d like I can submit the test case demoing this, the specific addon we used this with and had it break on was https://github.com/Addepar/ice-pop

[Turbo87]

The stripping transform errors, which causes builds to break IIRC. If you’d like I can submit the test case demoing this

yes, please

[marcoow]

👍

[pzuraq]

Looks like this fix worked for that particular bug (that’s what I get for commenting on PRs before I’ve had my coffee 😜), will let you know if any other issues come up