-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and simplified README file #48
Conversation
... and remove the now redundant "Why" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just a few small change requests
@@ -82,65 +51,47 @@ allows to encode more data in the markup like e.g. the post's id: | |||
</article> | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to add an example for a component with some data-test-*
attributes, e.g.:
{{comments-list data-test-comments-for=post.id}}
or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
</article> | ||
``` | ||
- Automatically binds properties starting with `data-test-` on all components | ||
for development/testing builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can leave the "for development/testing builds" as it might confuse people. Basically we're always doing that (regardless of the env) and strip these assignments when strip
is true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not quite true, the initializer is only included when we're not stripping. in other words: in production mode there is not initializer and no automatic binding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right but the point is that this doesn't actually depend on the environment but on the strip
setting (which happens to default on the env).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we probably shouldn't mention "for production builds" above either?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, good point - let's maybe just leave it as it is ;)
`ember-test-selectors` makes sure to remove all these `data-test-*` attributes in the | ||
`production` environment so that __users will have perfectly clean HTML | ||
delivered__: | ||
Once you've done that you can use our `testSelector()` function to create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should our
be the
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Rendered