Add support for component data-test-* attributes without values #57
Conversation
This adds support for `{{my-component data-test-foo}}`.
Basically, this adds a handlebars transform that converts the previous
example to `{{my-component data-test-foo=true}}`.
for Ember 1.13 compat
| @@ -0,0 +1,42 @@ | |||
| /* eslint-env node */ | |||
| var TEST_SELECTOR_PREFIX = /data-test-.*/; | |||
There was a problem hiding this comment.
Can we import this from elsewhere so we don't have to define it at several locations? We also might want to make it configurable in the future.
There was a problem hiding this comment.
yes, but I'd like to do that in a separate PR since we already have quite a bit of duplication around that regex
| @@ -9,3 +9,5 @@ | |||
| <div class="test5">{{data-test-component data-test="foo"}}</div> | |||
|
|
|||
| <div class="test6">{{data-test-component data-non-test="foo"}}</div> | |||
|
|
|||
| <div class="test7">{{data-test-component data-test-without-value}}</div> | |||
There was a problem hiding this comment.
We should have a test for the block form as well:
| @@ -9,3 +9,5 @@ | |||
| <div class="test5">{{data-test-component data-test="foo"}}</div> | |||
|
|
|||
| <div class="test6">{{data-test-component data-non-test="foo"}}</div> | |||
|
|
|||
| <div class="test7">{{data-test-component data-test-without-value}}</div> | |||
There was a problem hiding this comment.
Would a test case for {{component data-test}} similar to .test5 we have now be helpful?
| @@ -0,0 +1,42 @@ | |||
| /* eslint-env node */ | |||
| var TEST_SELECTOR_PREFIX = /data-test-.*/; | |||
There was a problem hiding this comment.
We have such a regex already in addon/utils/bind-data-test-attributes.js. I think it makes sense to refactor this into a shared function like isTestSelector. Would that make sense?
There was a problem hiding this comment.
I guess the problem is that one uses ES6 modules and the other CommonJS, so reducing duplication there might not be quite as easy
This PR is essentially #55 with a small change that restores Ember 1.13 compatibility.