Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ESLint config from eslint-config-simplabs #64

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Import ESLint config from eslint-config-simplabs #64

merged 1 commit into from
Jan 27, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jan 27, 2017

@Turbo87 Turbo87 requested review from marcoow and gr0uch January 27, 2017 10:44
marcoow
marcoow approved these changes Jan 27, 2017
View reviewed changes
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

gr0uch
gr0uch suggested changes Jan 27, 2017
View reviewed changes
Copy link

@gr0uch gr0uch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need .eslintrc anymore, just use eslintConfig in package.json.

http://eslint.org/docs/user-guide/configuring

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Jan 27, 2017

@sapeien I'm not sure about the precedence there. The ember-cli-eslint project will regenerate the file again once the blueprint runs and I don't know who will win then. I'd prefer to keep the file for now.

@gr0uch
Copy link

gr0uch commented Jan 27, 2017

It looks like ember-cli-eslint overrides the highest priority config :/

http://eslint.org/docs/user-guide/configuring#configuration-file-formats

@gr0uch gr0uch merged commit 7167a3c into mainmatter:master Jan 27, 2017
@Turbo87 Turbo87 deleted the eslint branch January 27, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr0uch gr0uch gr0uch approved these changes

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Turbo87 @gr0uch @marcoow