Switch to treeForAddonTestSupport #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Apr 3, 2017
| treeForAddonTestSupport(tree) { | ||
| // intentionally not calling _super here | ||
| // so that can have our `import`'s be | ||
| // import testSelector from 'ember-test-selectors'; |
There was a problem hiding this comment.
I'm not sure I understand. What tree would _super return?
There was a problem hiding this comment.
I can have a look. I just did the implementation based on example in #87.
There was a problem hiding this comment.
_super would return same tree but with namespace including the sub folder -
destDir: /${this.moduleName()}/test-support
_super also returns already preprocessed js files.
Turbo87
force-pushed
the
treeForAddonTestSupport
branch
from
700fc4d to
06d3eab
Compare
Turbo87
added a commit
that referenced
this pull request
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #87