Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-jest #1801

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Dec 31, 2022

@@ -52,7 +52,7 @@ describe('assert.dom(...).doesNotHaveAttribute()', () => {
]);
});

test('fails for wrong content (string value)', () => {
test('fails for wrong content (boolean value)', () => {
Copy link
Contributor Author

@bmish bmish Dec 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detected by no-identical-title. The previous test case is testing type which is a string attribute whereas this test case is testing required which is a boolean attribute.

@Turbo87 Turbo87 merged commit 669371b into mainmatter:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants