Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to V2 Addon #2028

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Convert to V2 Addon #2028

merged 5 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. npx ember-addon-migrator extract-tests --addon-location qunit-dom --i… 

    …n-place

Restore workflows, unchanged

Put some documentation config / files back and get 'docs' building working

Looks like all of ci.yml should work now

Cleanup and get tests passing

Add lint:fix script

Get lints passing

Move renovate config back out to the root

release.yml should be up-to-date now as well

Restore ember-try config

Remove test:ember from the addon, because the test app has been extracted

Update ci.yml for compatibility testing

Move projects in to packages folder

Move back out to root of directory, because now is not the time to restructure again -- can happen later
    @NullVoxPopuli
    NullVoxPopuli committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5e42118 View commit details
    Browse the repository at this point in the history

  2. V2 Conversion 

    Remove old files and dependencies from qunit-dom

Add new test index.html that demonstrates the problem in mainmatter#2022

Fix exports

Ah, so we do compile to ESM already

We have to remove the ember-addon keyword because we don't want to provide an addon-main and then have a dependency on @embroider/addon-shim
    @NullVoxPopuli
    NullVoxPopuli committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    388e29d View commit details
    Browse the repository at this point in the history

  3. Remove note matrix test

    @NullVoxPopuli
    NullVoxPopuli committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    405d77e View commit details
    Browse the repository at this point in the history

  4. Ensure modern dev deps

    @NullVoxPopuli
    NullVoxPopuli committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5ce0f55 View commit details
    Browse the repository at this point in the history

  5. Use real type=module, ESM, publint, and arethetypeswrong

    @NullVoxPopuli
    NullVoxPopuli committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    11b216e View commit details
    Browse the repository at this point in the history