Adds regex support for CSS class assertions #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 20, 2019 22:41
This is a preparatory step before adding regex support
This is a preparatory step before adding regex support
All CSS classes must not match. If any of them match the assertion will return false. The 'hasNoClass' and 'lacksClass' alias functions now accept RegExp as well.
This update documents the newly-added RegExp support within the 'hasClass' and 'doesNotHaveClass' assertions.
timiyay
commented
Aug 20, 2019
timiyay
commented
Aug 20, 2019
Turbo87
changed the title
|
Thanks for the review @Turbo87 🙏 |
|
I've opened this PR ready to merge on an Aussie Monday morning, and realised I don't have merge permissions 😆 @Turbo87 Is the PR mergeable as-is, or can I help with any extra work to get it over the line? |
|
whoops, sorry, forgot about this MR 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RegExp support to the
hasClassanddoesNotHaveClassassertions, as suggested in #450.Both functions now accept
string|RegExp, in the same vein ashasText.Each CSS class present on the target element will be matched against the RegExp, and:
hasClassassertion to returntrue, at least one CSS class must match; anddoesNotHaveClassassertion to returntrue, none of the CSS classes may matchResolves #450