fix: fix armbian-release file error #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get mainsail release shown in moonraker we need that 'hacky' solution Signed-off-by: Stephan Wendel <me@stephanwe.de>
meteyou
approved these changes
Sep 25, 2023
mryel00
approved these changes
Sep 25, 2023
Since this is not an issue related to the armbian module, but related to the release file of mainsailos (or choosen distname) it belongs to this distro instead of the general armbian module. Therefore refactoring into mainsailos module. Signed-off-by: Stephan Wendel <me@stephanwe.de>
Signed-off-by: Stephan Wendel <me@stephanwe.de>
meteyou
approved these changes
Oct 2, 2023
KwadFan
added a commit
to KwadFan/MainsailOS-dev
that referenced
this pull request
Oct 17, 2023
Since we applied PR mainsail-crew#241 and PR mainsail-crew#242 This function always returns no value. Which leads to errors in enabling SPI Interface by default. This should fix this behaviour Signed-off-by: Stephan Wendel <me@stephanwe.de>
KwadFan
added a commit
to KwadFan/MainsailOS-dev
that referenced
this pull request
Oct 17, 2023
Since we applied PR mainsail-crew#241 and mainsail-crew#242, this function always doesnt give the right value, which leads to unwanted behaviour in enabling SPI during build. As we no longer rename the release file, we have to use its original location in '/etc/armbian-release' ( Or '/etc/orangepi-release' if Opi Image is used ) Signed-off-by: Stephan Wendel <me@stephanwe.de>
KwadFan
added a commit
that referenced
this pull request
Oct 20, 2023
Since we applied PR #241 and #242, this function always doesnt give the right value, which leads to unwanted behaviour in enabling SPI during build. As we no longer rename the release file, we have to use its original location in '/etc/armbian-release' ( Or '/etc/orangepi-release' if Opi Image is used ) Signed-off-by: Stephan Wendel <me@stephanwe.de>
KwadFan
added a commit
to KwadFan/MainsailOS-dev
that referenced
this pull request
Oct 28, 2023
To get mainsail release shown in moonraker we need that 'hacky' solution --------- Signed-off-by: Stephan Wendel <me@stephanwe.de>
KwadFan
added a commit
to KwadFan/MainsailOS-dev
that referenced
this pull request
Oct 28, 2023
Since we applied PR mainsail-crew#241 and mainsail-crew#242, this function always doesnt give the right value, which leads to unwanted behaviour in enabling SPI during build. As we no longer rename the release file, we have to use its original location in '/etc/armbian-release' ( Or '/etc/orangepi-release' if Opi Image is used ) Signed-off-by: Stephan Wendel <me@stephanwe.de>
miklschmidt
pushed a commit
to Rat-OS/RatOS
that referenced
this pull request
Feb 25, 2024
To get mainsail release shown in moonraker we need that 'hacky' solution --------- Signed-off-by: Stephan Wendel <me@stephanwe.de>
miklschmidt
pushed a commit
to Rat-OS/RatOS
that referenced
this pull request
Feb 25, 2024
Since we applied PR mainsail-crew#241 and mainsail-crew#242, this function always doesnt give the right value, which leads to unwanted behaviour in enabling SPI during build. As we no longer rename the release file, we have to use its original location in '/etc/armbian-release' ( Or '/etc/orangepi-release' if Opi Image is used ) Signed-off-by: Stephan Wendel <me@stephanwe.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get mainsail release shown in moonraker we need that 'hacky' solution